Comments on: Why does MySQL’s version comment change when logging is enabled?

By: Raghavendra Prabhu

Raghavendra Prabhu — Sun, 17 Feb 2013 21:49:12 +0000

Some interesting MySQL archaeology in the above comments!

By: sbester

sbester — Mon, 04 Feb 2013 19:13:21 +0000

http://bugs.mysql.com/bug.php?id=57628
(remove the useless -log suffix from server version)

By: Sergei

Sergei — Mon, 04 Feb 2013 07:58:48 +0000

Laurynas,

you need to go deeper :)

The previous version of this line – before that revno 1346.620.1 – looked like

if (opt_log || opt_update_log || opt_slow_log || opt_bin_log)
strcat(server_version,”-log”);

it has no comment yet, and it is from the revision

revno: 2
revision-id: sp1r-bk@work.mysql.com-20000731192914-08846
parent: sp1r-bk@work.mysql.com-20000731191005-11438
committer: bk@work.mysql.com
timestamp: Mon 2000-07-31 21:29:14 +0200
message:
Import changeset

So, here you are. It’s from before-bk days, if Monty has the old CVS repository, he might be able to look this line up. Otherwise nobody can/

By: Rob Smith

Rob Smith — Mon, 04 Feb 2013 07:38:34 +0000

My wager is it’s a quick hack to know if they can just ask for the logs that they know exist or if they have to get the reporter to turn on logging and reproduce the bug before they can get logged information.

By: Laurynas

Laurynas — Mon, 04 Feb 2013 06:35:45 +0000

mysqld.cc has set_server_version() which has

if (opt_log || opt_update_log || opt_slow_log || opt_bin_log)
strmov(end, “-log”); // This may slow down system

The “// This may slow down system” comment is priceless IMHO.

Bzr archeology traces this comment-but not the “-log” itself-to Monty:

revno: 1346.620.1
committer: monty@mysql.com
timestamp: Wed 2004-05-19 16:38:12 +0300
message:
Added support for projects ‘classic’, ‘classic nt’, ‘pro’ and ‘pro nt’
Ensured that all projects compile
Removed compiler warnings
Better setting of server_version variable.
Fix that make_win_src_distribution creates the privilege tables.